Improve type hinting

[SmileyChris]

make/prepare now return the correct type depending on _quantity

[berinhard]

Thanks for the contribution, but the CI is breaking due to a broken from __future__ import.

[timjklein36]

These changes actually introduce some breaks on my local machine for mypy. See output below:

# python -m mypy model_bakery
model_bakery/baker.py:114: error: Need type annotation for "baker"
model_bakery/baker.py:229: error: Incompatible types in assignment (expression has type "Optional[Type[_M]]", variable has type "Type[_M]")
model_bakery/baker.py:231: error: Incompatible types in assignment (expression has type "None", variable has type "Type[_M]")
model_bakery/baker.py:497: error: Name "instance" already defined on line 484
model_bakery/recipe.py:13: error: Need type annotation for "finder"
Found 5 errors in 2 files (checked 10 source files)

Compared with no failures against main locally.

@berinhard @amureki It seems like the tox-linter GH Action succeeded here, but it failed on my local machine. Any reason that you can think of for the inconsistency?

[SmileyChris]

Fixed mypy issues (and to follow up on what @timjklein36 was saying, the gh linter action definitely isn't working correctly -- if you drill into the output of the tox step, it's not doing the work it should be)

[berinhard]

Thanks for the updates @SmileyChris!

@timjklein36 I did run the mypy check locally and it's passsing:

$ python -m mypy model_bakery
Success: no issues found in 10 source files

Is it failing for you even after the updates on this PR?

[timjklein36]

I have some questions about the implementation. Some of my confusion may come from not being very familiar with generic types in Python, so I apologize if that is the case.

[timjklein36]

@berinhard mypy is now succeeding locally for me. Once I get clarification on my questions above, I will be prepared to accept the PR.

[SmileyChris]

Renamed. The same overload patterns could also be applied to recipes, but for the sake of smaller PRs, I can submit that separately.

[amureki]

@berinhard @amureki It seems like the tox-linter GH Action succeeded here, but it failed on my local machine. Any reason that you can think of for the inconsistency?

I guessed that it is because of different Python versions in GitHub Actions config and tox. Here is a separate PR to fix it:
#262

[belkka]

I've come here being ready to make exaclty same PR. Nice to see it's already done and merged! 🎉