Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multi-database support #126

Merged
merged 14 commits into from
Nov 12, 2020
Merged

Enable multi-database support #126

merged 14 commits into from
Nov 12, 2020

Conversation

berinhard
Copy link
Member

@berinhard berinhard commented Nov 8, 2020

Fixes #94

This PR introduces the new parameter _using to baker API so callers can specify which database they want to use. If no value, it uses django's default DB.

This PR was created during Python Brasil 2020 with the amazing help from @flavioamieiro @rhenanbartels @mazulo @berrondo

Copy link
Contributor

@anapaulagomes anapaulagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, really cool feature! 👏🏽 Thanks you all for bringing this one to Model Bakery!

I left minor comments. To be honest, I haven't had the chance to use multiple databases with Django yet. It was a nice chance to read about it. :)

berinhard and others added 2 commits November 12, 2020 13:57
Co-authored-by: Ana Paula Gomes <apgomes88@gmail.com>
@berinhard
Copy link
Member Author

@anapaulagomes I've addressed all of your comments so I'll merge this and launch a new release!!! Thanks for your review =)

@berinhard berinhard merged commit 08750c0 into main Nov 12, 2020
@berinhard berinhard deleted the issue/94 branch November 12, 2020 17:22
@rumbarum
Copy link

rumbarum commented Sep 7, 2021

Thanks for great work! This help me a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create related object in the same database defined with _save_kwargs={"using":...}
3 participants