Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODCLUSTER-790 mod_cluster listener throws NPE when deploying a context in Tomcat - refine ContainerEventHandler#add contract and implementation #718

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

rhusar
Copy link
Member

@rhusar rhusar commented Aug 2, 2023

@rhusar rhusar marked this pull request as draft August 2, 2023 11:33
@rhusar rhusar marked this pull request as ready for review August 2, 2023 14:34
Copy link
Member

@pferraro pferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good.

@rhusar rhusar force-pushed the MODCLUSTER-790-v2 branch from efba2d6 to a222bb9 Compare August 2, 2023 14:40
…xt in Tomcat - refine ContainerEventHandler#add contract and implementation
@rhusar rhusar force-pushed the MODCLUSTER-790-v2 branch from a222bb9 to b56a618 Compare August 2, 2023 14:43
@rhusar rhusar requested a review from pferraro August 2, 2023 14:44
@rhusar rhusar merged commit 44a3996 into modcluster:main Aug 3, 2023
@rhusar rhusar deleted the MODCLUSTER-790-v2 branch August 3, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants