Fix for https://issues.redhat.com/browse/MODCLUSTER-785 #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jajik
approved these changes
Jun 26, 2023
| int sizew = balancer->workers->elt_size; | ||
| int j; | ||
| ptrw = balancer->workers->elts; | ||
| for (j = 0; j < balancer->workers->nelts; j++, ptrw=ptrw+sizew) { |
There was a problem hiding this comment.
It would be nice to add spaces around operators. Also, it might be cleaner to write ptrw += sizew, but it's up to you.
Comment on lines
+2213
to
+2217
| if (strcasecmp((*worker)->s->scheme, "HTTP") == 0 || | ||
| strcasecmp((*worker)->s->scheme, "HTTPS") == 0) { | ||
| if ((*worker)->s->port == ws_worker->s->port && | ||
| !strcmp((*worker)->s->route, ws_worker->s->route) && | ||
| !strcmp((*worker)->s->hostname, ws_worker->s->hostname)) { |
There was a problem hiding this comment.
It's a bit weird to me that for strcasecmp it is used == 0 and for strcmp it's negation. I would unify that. The former seems a bit cleaner.
There was a problem hiding this comment.
There are more place where we have == 0 in the conditions I think we should cleanup all those in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to fix 2.0.x / main the logic there uses only 1 worker.