MODCLUSTER-754 Modify ResetRequestSourceImpl to send STOP request when proxy not aware of a context #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhusar
previously requested changes
Jun 3, 2022
core/src/test/java/org/jboss/modcluster/mcmp/ResetRequestSourceTestCase.java
Outdated
Show resolved
Hide resolved
…n proxy not aware of a context When an app server connects to a proxy for the first time or after a disruption, it sends an INFO request to the proxy. Proxy responds with a list of contexts that are registered for given server, and their states. The context states returned from the proxy are compared to the actual states of contexts on the app server, and if necessary, the server should send ENABLE / STOP requests to bring the proxy to an up-to-date state. The change in this commit makes the app server send a STOP request for a context in case when the proxy response to an INFO request doesn't contain given context. The purpose of this STOP request is to enforce context registration on the proxy side.
|
Are there any further objections to this PR? |
|
Merged, thanks @TomasHofman ! |
|
Thanks @rhusar ! I created backport for EAP 7.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/MODCLUSTER-754
https://issues.redhat.com/browse/WFLY-16416
When an app server connects to a proxy for the first time or after a
disruption, it sends an INFO request to the proxy. Proxy responds with a
list of contexts that are registered for given server, and their states.
The context states returned from the proxy are compared to the actual
states of contexts on the app server, and if necessary, the server
should send ENABLE / STOP requests to bring the proxy to an up-to-date
state.
The change in this commit makes the app server send a STOP request for a
context in case when the proxy response to an INFO request doesn't
contain given context. The purpose of this STOP request is to enforce
context registration on the proxy side.