Be more specific about the lookup of an Ollie::Base subclass.

[parkr]

On line 27 of checker.rb, Ollie does a lookup of the class within the Ollie namespace to instantiate the checker for the key given. It fails in cases where the new class isn't loaded quickly enough to be chosen by the call to .const_get.

To illustrate this, consider a Rails app using Redis. We're interested in fetching some info, so we write an Ollie::Redis class which

The Redis class is defined on the main Object namespace. If the lookup occurs before the Ollie::Redis class I've defined is loaded, then I Ollie tries to instantiate a new Redis object, because .const_get is called before Ollie::Redis is loaded.

This fix forces the key to be loaded from the Ollie namespace as the README prescribes.

[meatballhat]

I believe this change introduces a dependency on ActiveSupport to get String#constantize. If there's a way for you to get desired behavior using plain ol' Ruby, I'd be all 👍. Thank you for contributing!

[parkr]

Absolutely right, sorry about that!

What do you think of this:

Ollie.const_get(class_name, false)

The false tells Module not to inherit the constants from Ollie's superclass, so this should also have the desired behaviour.

[meatballhat]

If that gives you the desired behavior and @nixterrimus likes it, then 👍 😸

[nixterrimus]

Thanks @parkr for the contribution!

Thanks @meatballhat for taking a look.

Looks good, merged in.

[parkr]

Thanks, @nixterrimus! We've built a library around this (a gem with various checkers for common services) and it's working splendidly so far. Thanks for writing it!