Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use c++17 as default instead of c++ #35

Closed
Quentin62 opened this issue Jan 29, 2023 · 0 comments
Closed

Use c++17 as default instead of c++ #35

Quentin62 opened this issue Jan 29, 2023 · 0 comments
Labels
MixtComp Concern the C++ library RMixtCompIO Concern the RMixtCompIO package: R interface of the C++ library

Comments

@Quentin62
Copy link
Collaborator

From Brian

random_shuffle was replaced by shuffle in C++11

Full message

That is

BET RMixtCompIO chngpt cit diversityForest fbati fdaPDE
genepop geojsonsf ggraph jsonify keyATM lmSubsets mapdeck
mapscanner matchingMarkets plfm prioritizr quanteda.textmodels
ranger ruimtehol sctransform sgd sirus spatialwidget stream

You will notice that R CMD check is now reporting

  • checking C++ specification ... NOTE
    Specified C++11: please update to current default of C++17

and we investigated for those packages if a non-default C++ standard was
actually needed. For all but 26 out of 1205 it was not. Common issues

random_shuffle was replaced by shuffle in C++11: BET RMixtCompIO cit
ggraph matchingMarkets sctransform sgd stream

bind1st was deprecated in C++11 and removed in C++17: chngpt

diversityForest ranger sirus: define own make_unique (a C++14 addition)
in a namespace but do not qualify the usages.

fbati genepop quanteda.textmodels : 'data' clashes with C++17 headers
which have std::data.

CRAN submissions will now auto-reject packages with this NOTE, so do
update before your next submission.
@Quentin62 Quentin62 added MixtComp Concern the C++ library RMixtCompIO Concern the RMixtCompIO package: R interface of the C++ library labels Jan 29, 2023
@Quentin62 Quentin62 mentioned this issue Feb 3, 2023
Merged
@Quentin62 Quentin62 mentioned this issue Feb 11, 2023
Merged
Quentin62 added a commit that referenced this issue Feb 12, 2023
@Quentin62 @vkubicki
fix: clang error and c++17 deprecation #34 #35 #38
55b9b69 
* -= method for iterators

* boost -> std in multinomial statistics

* postfix operators for iterators

* prefix ++ -- return the value before application

* tests(MixtComp): change tolerance

* refactor(MixtComp): refactor deprecated std::iterator #38

* feat(RMixtCompIO): use c++17 as standard

* .clang-format added and applied on two sources

* doc

* doc

* corecting the corrections

* iterator include removed

* Correcting the corrections, once again

* missing ref

* trivial copy constructors removed

* unuglyfying

* ConstIterator(Iterator &other)

* ConstIterator(const Iterator &other)

---------

Co-authored-by: Vincent KUBICKI <vincent.kubicki@laposte.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MixtComp Concern the C++ library RMixtCompIO Concern the RMixtCompIO package: R interface of the C++ library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Quentin62