win32 details

Signed-off-by: falkTX <falktx@falktx.com>

src/plugin/ChildProcess.hpp

@@ -60,17 +60,29 @@ class ChildProcess
             if (i != 0)
                 cmd += " ";
 
-            // TODO quoted
-            cmd += args[i];
+            if (std::strchr(args[i], ' ') != nullptr)
+            {
+                cmd += "\"";
+                cmd += args[i];
+                cmd += "\"";
+            }
+            else
+            {
+                cmd += args[i];
+            }
         }
 
-        STARTUPINFOA si = {};
+        wchar_t wcmd[PATH_MAX];
+        if (MultiByteToWideChar(CP_UTF8, 0, cmd.data(), -1, wcmd, PATH_MAX) <= 0)
+            return false;
+
+        STARTUPINFOW si = {};
         si.cb = sizeof(si);
 
         d_stdout("will start process with args '%s'", cmd.data());
 
-        return CreateProcessA(nullptr,    // lpApplicationName
-                              &cmd[0],    // lpCommandLine
+        return CreateProcessW(nullptr,    // lpApplicationName
+                              wcmd,       // lpCommandLine
                               nullptr,    // lpProcessAttributes
                               nullptr,    // lpThreadAttributes
                               TRUE,       // bInheritHandles

src/plugin/DesktopPlugin.cpp

@@ -95,7 +95,7 @@ class DesktopPlugin : public Plugin,
     bool run() override
     {
        #ifdef DISTRHO_OS_WINDOWS
-        #define APP_EXT ".ext"
+        #define APP_EXT ".exe"
        #else
         #define APP_EXT ""
        #endif
@@ -121,7 +121,7 @@ class DesktopPlugin : public Plugin,
                 "-S",
                 "-n", servernameStr.buffer(),
                 "-C", jacksessionStr.buffer(),
-                "-d", "desktop",
+                "-d", "mod-desktop",
                 "-r", sampleRateStr.buffer(),
                 nullptr
             };

src/plugin/Makefile

@@ -19,7 +19,9 @@ FILES_UI = DesktopUI.cpp NanoButton.cpp
 
 ifeq ($(MACOS),true)
 FILES_UI += WebView.mm
-else ifeq ($(LINUX),true)
+else ifeq ($(WINDOWS),true)
+FILES_UI += WebViewWin32.cpp
+else
 FILES_UI += WebViewX11.cpp
 endif
 
@@ -33,6 +35,9 @@ include ../DPF/Makefile.plugins.mk
 
 BUILD_CXX_FLAGS += -DVERSION='"$(shell cat ../../VERSION)"'
 
+BUILD_CXX_FLAGS += -pthread
+LINK_FLAGS += -pthread
+
 ifeq ($(MACOS),true)
 LINK_FLAGS += -framework IOKit -framework WebKit
 else ifeq ($(WINDOWS),true)

src/plugin/WebViewWin32.cpp

@@ -0,0 +1,29 @@
+// SPDX-FileCopyrightText: 2023-2024 MOD Audio UG
+// SPDX-License-Identifier: AGPL-3.0-or-later
+
+#include "WebView.hpp"
+
+START_NAMESPACE_DISTRHO
+
+// -----------------------------------------------------------------------------------------------------------
+
+void* addWebView(const uintptr_t parentWinId, const uint port)
+{
+    return nullptr;
+}
+
+void destroyWebView(void* const webviewptr)
+{
+}
+
+void reloadWebView(void* const webviewptr)
+{
+}
+
+void resizeWebView(void* const webviewptr, const uint offset, const uint width, const uint height)
+{
+}
+
+// -----------------------------------------------------------------------------------------------------------
+
+END_NAMESPACE_DISTRHO