Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the optimization UI #3781

Merged
merged 10 commits into from
Oct 15, 2023
Merged

Clean up the optimization UI #3781

merged 10 commits into from
Oct 15, 2023

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Oct 15, 2023

What it looks like:
Optimization explained
This PR does the following:

  1. Add localization tags.
  2. Move the optimize button to the burn.
  3. Move the optimization parameters up a bit, and makes inclination optimization optional.
  4. Change the interface to separate the creation of an optimization driver from the actual run of the optimization driver. The driver is updated when the parameters change. This means in particular that changes the parameters interrupts the optimization.

eggrobin
eggrobin approved these changes Oct 15, 2023
View reviewed changes
ksp_plugin/interface_flight_plan.cpp Outdated
return m.Return();
}

// REMOVE BEFORE FLIGHT: Sort the functions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

@eggrobin eggrobin added the LGTM label Oct 15, 2023
@pleroy pleroy merged commit 805e19b into mockingbirdnest:Wilkinson Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eggrobin eggrobin eggrobin approved these changes

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pleroy @eggrobin