Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.2.0 #69

Merged
merged 69 commits into from
Apr 10, 2022
Merged

V1.2.0 #69

merged 69 commits into from
Apr 10, 2022

Conversation

mochi-co
Copy link
Collaborator

Merges v1.2.0 into master

Joshua MacDonald and others added 30 commits February 26, 2022 22:53
Support non-UTF8 payloads per MQTT specification
b0dcaab
@mochi-co
Merge pull request #29 from jmacd/jmacd/payload_not_utf8
9c6f602 
Support non-UTF8 payloads (per MQTT specification)
@jmacd
Move two WaitGroup.Add calls (#36)
9f1c387
@jmacd
Wrap packet errors with cause information (#39)
17253ad
@jmacd
Add an OnError handler; report the reason for disconnects. (#38)
0a5f6d3
Add missing method comments
325d44d
Add Keyed fields to events.Client for readability and go vet
d6a92cc
Fix typo
7e970d3
Merge branch 'master' of https://github.com/mochi-co/mqtt into v1.1.2
ab25083 
# Conflicts:
#	server/internal/clients/clients.go
@stffabi
Publish: Set the retain flag in the fixedheader (#42)
1f86168 
* Publish: Set the retain flag in the fixedheader
Fix incorrect test
9f44712 
The previous publish inline test incorrectly approved retain packets without retain=true fixedheader values.
@stffabi
Subscribe: Only send retained messages if ACLs has allowed subscripti…
f5fc5e8 
…on to the topic
@mochi-co
Merge pull request #46 from stffabi/bugfix/acls-retain
fdbfff5 
Subscribe: Only send retained messages if ACLs has allowed subscription to the topic
Merge branch 'master' of https://github.com/mochi-co/mqtt into v1.1.2
5de12d0
Combines two fixes
c664359
@stffabi
Events: Add OnProcessMessage event
7b4e797 
This event gets called right after ACL checking but before any other
Fields of the packet get evaluated.
@mochi-co
Merge pull request #51 from jmacd/jmacd/noracefix
6a3cbd6 
Two no-functional-change cleanups combined
@deadprogram
docker: add initial simple Dockerfile
5d72306
@soyoo
typo
0e7ccfe
@mochi-co
Merge pull request #58 from soyoo/patch-1
0d4b0a8 
typo
@mochi-co
Merge pull request #57 from hybridgroup/v1.2.0-docker
51a2eb5 
docker: add initial simple Dockerfile
Update go mod to ensure bolt is using 1.3.5
d946a9a 
Bolt 1.3.6 fails to build correctly and has been removed, so rollback to bolt 1.3.5. Also upgrade to Go 1.18
Add Server Options
a006042 
Adds a new struct of server options which can be used to override default properties. A new options-accepting NewServer function has been created to supersede the New method, which is now deprecated.
Use internal default values instead of relying on passed value
18629ae
Update example code to use new NewServer function instead of deprecat…
99c96c8 
…ed New
Update code to use new NewServer function instead of deprecated New
e4f0291
remove deprecated log message
8e7098a
add tests for new NewServer function
70def39
Add example implementation
74699f0
Update readme with server options
6aec3a8
mochi and others added 25 commits April 10, 2022 01:32
Clarify error messages
f60d2dc
refactor connSetup for clarity
429b722
Refactor establishconnection to prevent same-id disconnects
70f52c8
refactor clients for buffer releasing
5d343c1
clear buffers after deferred stop
eef3592
test clarbuffers
b6fd25b
Use package errors instead of strings
6298a87
Track number of pool blocks in use
54e2d04
Export R/W buffer values so they can be assessed in tests without cau…
f2dd5b6 
…sing races
Update EstablishConnection tests to ensure buffers and pool are corre…
0f67d9e 
…ctly released after use
Correctly return R value of retainMessage
6f9f62e
Expect correct r values for RetainMessage
352a71f
Store retained message based on corrected r value
1bc0127
Expose CleanSession value for checking
bae2579
Abandon client state if the existing client specified a cleansession
45c4a64
Remove unused code
82cb759
Add comments
bbc22fa
Check for protocol violation errors
fc00112
accept any error for invalid protocol due to races
5cb8a08
only check final outcome due to races
94aeacf
@mochi-co
Merge pull request #67 from mochi-co/release-client-buffers
d97b4bb 
Release client buffers
Merge branch 'v1.2.0' of https://github.com/mochi-co/mqtt into fix-st…
ee081d0 
…ore-retained
@mochi-co
Merge pull request #68 from mochi-co/fix-store-retained
60cd972 
Fix Store Retained Messages
update readme for new events
e3bdfc1
use NewServer instead of New
765f6e7
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2144889772

  • 315 of 328 (96.04%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 98.527%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server/internal/circ/pool.go 5 7 71.43%
server/internal/clients/clients.go 53 55 96.36%
server/server.go 194 203 95.57%
Files with Coverage Reduction New Missed Lines %
server/server.go 1 98.57%
Totals Coverage Status
Change from base Build 1998670043: -0.5%
Covered Lines: 2675
Relevant Lines: 2715
💛 - Coveralls

@mochi-co mochi-co merged commit 3a15cc3 into master Apr 10, 2022
@mochi-co mochi-co deleted the v1.2.0 branch April 10, 2022 19:28
@mochi-co mochi-co restored the v1.2.0 branch April 10, 2022 19:28
@mochi-co mochi-co deleted the v1.2.0 branch April 10, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mochi-co @coveralls @jmacd @stffabi @deadprogram @soyoo