add description for MaximumClientWritesPending #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls see ref MaximumClientWritesPending建议添加文档说明其意义及影响 #410 |
|
You may also want to point it out that setting this value very low may result in lost messages for subscribers, especially for busy topics. One can monitor the metrics MessagesDropped when that occurred. I do agree the current default is biased towards not dropping messages, perhaps 128 may be sufficient, which translates to a fixed memory cost of 1KB per connection. That makes it smaller than ClientNetReadBufferSize and ClientNetWriteBufferSize, both at 2KB. |
|
Always happy to have more extensive documentation, thank you @CendealChen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.