Add BadgerDB garbage collection. #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8318670794Details
💛 - Coveralls |
dgduncan
reviewed
Feb 28, 2024
…etailed comments in the example.
dgduncan
approved these changes
Mar 5, 2024
|
@werbenhu @dgduncan This generally looks like a great enhancement to me (on my phone at least), and I'm going to try to look at it as soon as I can. Currently I am on the other side of the world (Tasmania) and I've had very little signal or internet for the last couple of weeks. I will be returning to more populated areas in a week. I also hope to finalise some of the other improvements we've discussed like the file based config. Thank you for keeping everything going! |
mochi-co
approved these changes
Mar 18, 2024
|
How to use it? Can 't ust make it a default config??? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issues #370, #369, and #363. I've tested it myself under the condition of setting the log file size to 1MB. With 1000 clients repeatedly connecting and disconnecting with the same client ID, if GC is not enabled, the log file continues to grow indefinitely. Enabling the GC loop resolves this issue.