Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket reads for packets > 1 buffer size #260

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

ianrose14
Copy link
Collaborator

Fixes #259

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5557141269

  • 16 of 21 (76.19%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 98.874%

Changes Missing Coverage Covered Lines Changed/Added Lines %
listeners/websocket.go 16 21 76.19%
Totals Coverage Status
Change from base Build 5547676562: 0.2%
Covered Lines: 5269
Relevant Lines: 5329

💛 - Coveralls

@mochi-co mochi-co added the bug Something isn't working label Jul 14, 2023
Copy link
Collaborator

@mochi-co mochi-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ianrose14!

This looks good to me. As far as I can tell it's correct, and it works as far as I can see in my tests and websocket connections. I approve 👍🏻 If nobody has any concerns, I will probably merge it in tomorrow.

@mochi-co mochi-co self-assigned this Jul 14, 2023
@ianrose14
Copy link
Collaborator Author

Thanks @ianrose14!

This looks good to me. As far as I can tell it's correct, and it works as far as I can see in my tests and websocket connections. I approve 👍🏻 If nobody has any concerns, I will probably merge it in tomorrow.

Great, thanks for the fast review!

Also thanks for providing this package - we were previously using Google Cloud's IoT service, but that's getting shut down next month (😭) and this package has been really nice for developing our in-house alternative. 👏

@mochi-co mochi-co merged commit aec29e3 into mochi-mqtt:master Jul 16, 2023
@ianrose14 ianrose14 deleted the ianrose/fix-websocket-reads branch July 17, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websocket listener falls into infinite read loop for messages > ~2048 bytes
3 participants