add "fixture flowchart" to docs #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigtaub
reviewed
Sep 10, 2020
outsideris
reviewed
Sep 27, 2020
also add some references to global fixtures Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
4c72600 to
7b94d86
Compare
|
OK, I think I've addressed the responsiveness issue. I've also added a |
outsideris
suggested changes
Oct 9, 2020
| This flowchart will help you decide which of [hooks], [root hook plugins] or | ||
| [global fixtures] you should use. | ||
|
|
||
| {% include fixture-wizard.html %} |
There was a problem hiding this comment.
Including HTML is not handled properly and SVG is broken.
I don't know why even I checked it.
There was a problem hiding this comment.
ohh I know what happened. prettier broke it. I am not sure if this is a bug in prettier or liquid or eleventy, but when prettier reformats it, the svg breaks.
There was a problem hiding this comment.
OK, wrapping the svg in a div works. I think this is an 11ty bug
There was a problem hiding this comment.
- added source `.sketch` file to repo - enabled skip of supporter image download in 11ty via env var `MOCHA_DOCS_SKIP_IMAGE_DOWNLOAD` for faster iteration - made the links underline on hover Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
7b94d86 to
4fb2bb7
Compare
outsideris
approved these changes
Oct 10, 2020
|
(semver minor b/c it references other stuff that will land in a minor) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Munter You know more about web stuff than I do. Is this a reasonable way to use an SVG? In particular, I wanted to make portions of it clickable, and couldn't figure out how to do that without embedding the
<svg>into the page.