add link to Apex Ping to mochajs.org #3779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
Merged
|
Related issue #3783 |
|
Should this link be considered an endorsement? It's freaking huge... |
plroebuck
reviewed
Feb 28, 2019
| <main id="content"> | ||
| <section>{{ content }}</section> | ||
|
|
||
| <section id="more-sponsors"> |
There was a problem hiding this comment.
semantically, shouldn't this be using <aside>?
|
In the preview it doesn't look very nice, lost at the very bottom with tiny letters. It's not really a cordial thank-you. |
craigtaub
reviewed
Feb 28, 2019
|
|
||
| #more-sponsors { | ||
| margin: 200px auto; | ||
| padding-top: 100px; |
There was a problem hiding this comment.
Seems too much padding + margin (300px top total whitespace).
There was a problem hiding this comment.
Agreed.
margin: 100px auto;
padding-top: 50px;
|
I wrote and asked if there was a logo... I think this goes beyond ... |
outsideris
reviewed
Mar 4, 2019
|
|
||
| #more-sponsors { | ||
| margin: 200px auto; | ||
| padding-top: 100px; |
There was a problem hiding this comment.
Agreed.
margin: 100px auto;
padding-top: 50px;
| display: flex; | ||
| align-items: center; | ||
| border-top: 1px solid #ddd; | ||
| font-size: 0.8em; |
|
this is what he gave me for an image... I'll see if I can make it not so huge. |
|
This PR has been inactive for years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocha's creator (tj) now works for himself as/at Apex Software. As a thank-you, we should provide a link to his product.
Once this is merged, I'd like to deploy it live.
Sorry about my no-design skills!