Fix issue #325 (add better grep support to js api)

[davemckenna01]

Fix issue #325 - When testing in the browser, the mocha object now has a grep() method which you can chain like so: mocha.grep('foo').run() - with @shwaydogg

[tj]

we should use the Mocha prototype in ./lib/mocha.js, right now you can only pass a grep: option but it would be nice to have this there, allowing a regexp or a string

[davemckenna01]

Ah I see - I had it in my head that this was an enhancement to browser test running only. But ya we should totally make this api available in Node, etc.

One question: it appears that in the browser tests you have that you're not actually instantiating a Mocha object ... you're adding methods (specifically .run() and .setup()) to the Mocha constructor, and not using the Mocha.prototype methods. What's the reason for that?

Related to that, should we keep the code we have in support/tail.js?

[tj]

it is available to node, in ./lib/mocha.js, we need to do the opposite, bring the node js api to the client portion. A reasonable amount of tail.js would be replaced by ./lib/mocha.js

[shwaydogg]

Is the following the best way or an appropriate way to run mocha: programmatically / from the node REPL / test the API?

var mocha = require('./bin/_mocha');

mocha.run();

[tj]

@shwaydogg there's a js api now, but it's built to be.. an api haha not a super simple REPL thing, if you wanted that why not just use the CLI?

[davemckenna01]

Ok we've got mocha.grep() and new Mocha({grep:..}) working nicely - how would you like us to test this? Do you want tests a la Mocha itself:

describe('grep()', function(){
  it('should add a string to grep for', function(){
    var mocha = new Mocha({grep:/bar/});
    console.log(mocha);
    assert.equal(/bar/, mocha.grep);
  });
});

or a la what you have in test/jsapi/index.js:

var mocha = new Mocha({
  ui: 'bdd',
  globals: ['okGlobalA', 'okGlobalB'],
  // ignoreLeaks: true,
  growl: true
});

...

mocha.run(function(){
  console.log('done');
}).on('pass', function(test){
  // console.log('... %s', test.title);
});

[tj]

awesome :D

Ideally we have some unit tests, my test/jsapi/index.js is just because I dont have time, so probably something more like the first

[davemckenna01]

Tests added - should be good to go :)

[tj]

weird git wont let me curl the .patch, I was going to squash these into one commit

[tj]

this is just me but I stay away from overly defensive programming , I'd do:

this.options.grep = 'string' == typeof re
  ? re = new RegExp(re)
  : re;

same with above

[tj]

my bad, no clue why i re-assigned re:

this.options.grep = 'string' == typeof re
  ? new RegExp(re)
  : re;

[davemckenna01]

Cool - I cleaned up those lines - ya the commits are a mess sorry. Curling the patch works for me.

[davemckenna01]

I can just create a new branch with the one commit, and pull request that, if that's easier for you.

[davemckenna01]

Slipped by me too - fixed.