-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update list of published files in package.json #3547
Conversation
as long as you're here, we should be documenting:
|
@plroebuck specifying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation says having both bin
and directories.bin
is an error (though npm
itself does this). directories.doc
had incorrect directory name. The two remaining were prefixed for relative reference.
Left wondering about directories.doc
as it really feels more like "directories.www" than actual documentation -- unclear (actually doubtful) whether it should be defined as such given our usage.
I'd be good to just remove directories.doc
.
"directories": {
"doc": "./docs",
"lib": "./lib",
"test": "./test"
},
This field should be added.
"bugs": {
"url": "https://github.com/mochajs/mocha/issues/"
},
Minor modification of existing field to add trailing slash.
"homepage": "https://mochajs.org/",
- this will fix a problem with npm (potentially) publishing certain files which should always be ignored; see npm/npm-packlist#14. - also fixes issue with growl images not getting published! - add `directories` property for metadata PRO TIP: use `npm pack --dry-run` to see what would be included in published tarball.
@plroebuck please see changes in 0f26b58 |
"index.js", | ||
"mocha.css", | ||
"mocha.js", | ||
"browser-entry.js" | ||
], | ||
"directories": { | ||
"lib": "lib", | ||
"test": "test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decide not to express these as explicit relative paths?
"lib": "./lib",
"test": "./test"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why this matters...
which should always be ignored; see Run defaultRules recursively to avoid publishing .DS_Store, .swp, etc npm/npm-packlist#14.
PRO TIP: use
npm pack --dry-run
to see what would be included inpublished tarball.