Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unescaped grep regex when set via html reporter #1697

Closed
wants to merge 1 commit into from
Closed

Fix unescaped grep regex when set via html reporter #1697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions support/tail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,9 @@ process.on = function(e, fn){
* Expose mocha.
*/

var Mocha = global.Mocha = require('mocha'),
mocha = global.mocha = new Mocha({ reporter: 'html' });
var Mocha = global.Mocha = require('mocha')
, mocha = global.mocha = new Mocha({ reporter: 'html' })
, escapeRe = require('browser/escape-string-regexp');

// The BDD UI is registered by default, but no UI will be functional in the
// browser without an explicit call to the overridden `mocha.ui` (see below).
Expand Down Expand Up @@ -139,7 +140,7 @@ mocha.run = function(fn){
mocha.globals('location');

var query = Mocha.utils.parseQuery(global.location.search || '');
if (query.grep) mocha.grep(new RegExp(query.grep));
if (query.grep) mocha.grep(new RegExp(escapeRe(query.grep)));
if (query.fgrep) mocha.grep(query.fgrep);
if (query.invert) mocha.invert();

Expand Down