replaced non-ANSI.SYS escape sequence in landing reporter, fixes #211 #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this PR need anything else in order to be merged? |
|
I'd like someone else who uses this reporter in another terminal to verify that the patch works. |
|
Fair enough. |
|
I've just tested this patch and fixes it alright! :) |
|
Great! |
travisjeffery
pushed a commit
that referenced
this pull request
Oct 13, 2014
replaced non-ANSI.SYS escape sequence in landing reporter, fixes #211
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The landing reporter breaks in iTerm2. I guessed the cause was using
\u001b[4F, the not-ANSI.SYS CPL (Cursor Previous Line) escape sequence. I've replaced it with two ANSI.SYS escape sequences, CUB (Cursor Back) and CUU (Cursor Up).I've also fixed an issue in which executing mocha using the landing reporter in any terminal line but the first one was erasing one line more than intended. In case of executing the mocha command directly, it was erasing the mocha prompt line. Two images are worth 2000 words:
after executing mocha:
(notice the missing
mocha -u tdd --reporter landingline)