Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suite.timeout() etc #599

Closed
tj opened this issue Oct 3, 2012 · 6 comments
Closed

suite.timeout() etc #599

tj opened this issue Oct 3, 2012 · 6 comments
Labels
type: feature enhancement proposal

Comments

@tj
Copy link
Contributor

tj commented Oct 3, 2012

describe(..., function(){
  this.timeout('5s');
  ...
  slow stuff
})
@ghost
Copy link

ghost commented Oct 4, 2012

Does it mean, different timeouts per describe based on you put or not this parameter?

@tj
Copy link
Contributor Author

tj commented Oct 4, 2012

yeah currently if you do something like:

describe(..., function(){
  beforeEach(function(){ this.timeout(5000) })
})

it applies to the beforeEach hook itself, not the following test-cases so we have no way to define a timeout for multiple test-cases right now

@ghost
Copy link

ghost commented Oct 5, 2012

Let me know if this PR solves the problem. If that is the case, for me to make the adequate modifications in the mocha's document.

@tj tj closed this as completed in 3f81980 Oct 9, 2012
@domenic
Copy link
Contributor

domenic commented Oct 9, 2012

Eww more namespace collisions preventing me from attaching variables with certain names to the context :(

@rauchg
Copy link
Contributor

rauchg commented Oct 9, 2012

You can still overwrite it without issues.

On Tue, Oct 9, 2012 at 7:49 AM, Domenic Denicola
notifications@github.comwrote:

Eww more namespace collisions preventing me from attaching variables with
certain names to the context :(


Reply to this email directly or view it on GitHubhttps://github.com//issues/599#issuecomment-9263336
.

@tj
Copy link
Contributor Author

tj commented Oct 9, 2012

this was global before :p so that's even worse if you were assigning to it, assigning in the describe blocks would be a little weird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature enhancement proposal
Projects
None yet
Development

No branches or pull requests

3 participants