Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/gha: add Go 1.22, update various actions, add macos-12, ubuntu-24.04 #137

Merged
merged 9 commits into from
Jul 3, 2024

Conversation

thaJeztah
Copy link
Member

user: gofumpt

ci/gha: remove macos-11 (deprecated), update to macos-12

From the GitHub actions documentation 1;

The macos-11 label has been deprecated and will no longer be available
after 28 June 2024.

ci/gha: bump actions/setup-go to v5

Upgrades Node.js runtime from node16 to node20

ci/gha: bump actions/checkout to v4

Only a single commit is fetched by default, for the ref/SHA that triggered
the workflow. Set fetch-depth: 0 to fetch all history for all branches and
tags.

Makefile: bump golangci-lint to v1.59.1

mountinfo: rm unneeded errorlint annotation

Commit d6a5209 removed most errorlint
annotations, with one remaining.

golangci-lint v1.59.1 comes with errorlint v1.5.2, which contains
the fix 2 whitelisting all errno comparisons for errors coming from
x/sys/unix. Remove the annotation that is no longer needed.

ci/gha: add ubuntu-24.04 (current LTS)

Ubuntu 24.04 runners are now available (see 3)

ci/gha: add macos-14 (m1, arm64)

Add current macOS version, running on arm64 (see 4)

ci/gha: drop Go 1.20, add Go 1.22

Test with the current stable version of Go; keeping Go 1.17 as lower
boundary for now since it costs us little to keep supporting it.

thaJeztah added 9 commits July 3, 2024 09:57
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
From the GitHub actions documentation [1];

> The macos-11 label has been deprecated and will no longer be available
> after 28 June 2024.

[1]: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upgrades Node.js runtime from node16 to node20

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Only a single commit is fetched by default, for the ref/SHA that triggered
the workflow. Set fetch-depth: 0 to fetch all history for all branches and
tags.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Commit d6a5209 removed most errorlint
annotations, with one remaining.

golangci-lint v1.59.1 comes with errorlint v1.5.2, which contains
the fix [1] whitelisting all errno comparisons for errors coming from
x/sys/unix. Remove the annotation that is no longer needed.

[1]: polyfloyd/go-errorlint@c0e6cac

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Test with the current stable version of Go; keeping Go 1.17 as lower
boundary for now since it costs us little to keep supporting it.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah self-assigned this Jul 3, 2024
@thaJeztah thaJeztah merged commit 35f6c4e into moby:main Jul 3, 2024
19 checks passed
@thaJeztah thaJeztah deleted the refresh_ci branch July 3, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants