Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace legacy issue template with revised issue forms #5672

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

thompson-shaun
Copy link
Collaborator

Closes #5587

This PR replaces the deprecated legacy markdown template at .github/issue_template.md with new YAML-based forms for bug reports and feature requests. Blank issues are still allowed under this PR's configuration. An issue type is also added when available.

Note that for the forms most fields are required.

Additions

  • Issue template chooser added with links to discussions, slack and documentation
  • Bug report form
  • Feature request form

Reference

.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
url: https://github.com/moby/buildkit/discussions/new
about: Use Github Discussions to ask questions and/or open discussion topics.
- name: Documentation
url: https://docs.docker.com/build/buildkit/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should point to the more-complete internal docs instead: https://github.com/moby/buildkit/tree/master/docs

@thompson-shaun thompson-shaun force-pushed the add-issue-templates branch 2 times, most recently from 24fd0f3 to a75c687 Compare January 21, 2025 19:01
- name: Documentation
url: https://github.com/moby/buildkit/tree/master/docs
about: Read the documentation.
- name: Join the Docker Community on Slack
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in moby/moby we also added suggestions for reporting security issues (to make it more prominent that github is not the place for that)

https://github.com/moby/moby/blob/master/.github/ISSUE_TEMPLATE/config.yml#L3

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion! Adding.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thompson-shaun Hum it seems we now have duplicated security blocks because of this: https://github.com/moby/buildkit/issues/new/choose

image

We should remove this one so only the dynamic one is shown, similar to what we have on Buildx repo: https://github.com/docker/buildx/issues/new/choose

image

…ate config and forms

Signed-off-by: Shaun Thompson <shaun.thompson@docker.com>
@crazy-max crazy-max merged commit 9a39e2c into moby:master Jan 22, 2025
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github: Issue template is not working anymore
4 participants