docs: emphasize the fact that secrets aren't saved in cache #5211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was reading through the documentation trying to understand what's so special about secret type mount except for extra options it takes as I found that contents of bind mount doesn't get baked into the image too but it can be found in /var/lib/docker in contrary to secret type mount. I've learned that secret type mount uses tmpfs under the hood and my findings were confirmed by https://docs.docker.com/build/cache/invalidation/#general-rules: 'The contents of build secrets are not part of the build cache.'. I think it's worth emphasizing in the documentation. Fixes docker/docs#20436. Signed-off-by: Arkadiusz Drabczyk <arkadiusz@drabczyk.org>
dvdksn
reviewed
Aug 6, 2024
Fixes docker/docs#20436. Signed-off-by: Arkadiusz Drabczyk <arkadiusz@drabczyk.org>
crazy-max
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading through the documentation trying to understand what's so
special about secret type mount except for extra options it takes as I
found that contents of bind mount doesn't get baked into the image too
but it can be found in /var/lib/docker in contrary to secret type
mount. I've learned that secret type mount uses tmpfs under the hood
and my findings were confirmed by
https://docs.docker.com/build/cache/invalidation/#general-rules: 'The
contents of build secrets are not part of the build cache.'. I think
it's worth emphasizing in the documentation.
Fixes docker/docs#20436.
Signed-off-by: Arkadiusz Drabczyk arkadiusz@drabczyk.org