-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: frontend/gateway: leave mount type as nil for Windows #5077
base: master
Are you sure you want to change the base?
Conversation
Don't forget to sign-off your commits, see this failed run. |
da47264
to
2ef7a45
Compare
f83390c
to
534b6ff
Compare
534b6ff
to
dcfe789
Compare
Is this PR close to a ready state @billywr? Just wanted to make sure it didn't get lost ;) |
dcfe789
to
8b8061b
Compare
8b8061b
to
1da789b
Compare
f6c280a
to
5abf161
Compare
5abf161
to
dc8561e
Compare
fb193ed
to
6af1547
Compare
-Added a check to exclude Windows OS when adding bind mount types to container image bundle. -Bind types apply to Linux OS; hcsshim accepts empty bind types for Windows container creation. Signed-off-by: Billy Owire <billyowire95@gmail.com>
6af1547
to
e45cdd0
Compare
@profnandaa What's the state of this? Is it a temporary patch? Even if Windows doesn't call these mounts "type=bind" internally, this is still how they should be called in Dockerfile. |
Seems we will have to do this fix from the HCS side instead. Let us go over it with Billy once he's back from PTO next week. |
Added a check to exclude Windows OS when adding bind mount types to container image bundle.
Bind types apply to Linux OS; hcsshim accepts empty bind types for Windows container creation.
#4892
More info, what I was trying to achieve
I attempted to build a custom Docker frontend image(resides in dockerhub:docker.io/100909/dockerfile-4892) using the following Dockerfile:
The
dockerfile-frontend.exe
was built frombuildkit/frontend/dockerfile/cmd/dockerfile-frontend
.I created another Dockerfile referencing the custom frontend image:
# syntax=docker.io/100909/dockerfile-4892
I ran the following command:
This resulted in an error during container creation in
hcsshim
:I made changes in BuildKit to fix the error in step 3 and ran
buildctl
again.Container creation stage passes,
I am getting a new error shown below when building the custom dockerfile frontend as in step 2.
sh error: failed to solve: exit code: 2
This commit fixes the error in step 3.
@tonistiigi I am seeking ideas and comments.