dockerfile: fix missing source mapping for COPY --link command #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
daghack
approved these changes
Apr 23, 2024
profnandaa
approved these changes
Apr 23, 2024
AkihiroSuda
reviewed
Apr 23, 2024
| @@ -1340,11 +1340,10 @@ func dispatchCopy(d *dispatchState, cfg copyConfig) error { | |||
| copyOpts := []llb.ConstraintsOpt{ | |||
| llb.Platform(*d.platform), | |||
| } | |||
| copy(copyOpts, fileOpt) | |||
| copyOpts = append(copyOpts, fileOpt...) | |||
There was a problem hiding this comment.
Wondering if there is a linter to catch this kind of common mistake
AkihiroSuda
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
COPY --linkcommand lost its source mapping to the original Dockerfile when converted to LLB vertex. Regression from cc1499e#diff-905097ba6a4e36b3afbb1204e52315791dc0915f2a845c768bc84c6af5db1e1fR1075 progressgroup PR.@sipsma The previous code is clearly incorrect as it is copying to nil slice (that does nothing), but do check that I didn't miss any progressgroup logic.