solver: allow debugging specific builder steps #4410
Merged
+46
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds new environment variables for allowing debugging scheduler for only specific steps. This is useful because the scheduler debugging is quite verbose so if you run it on production builds it can generate lots of data that is hard to analyze. Old behavior is unchanged. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
crazy-max
reviewed
Nov 17, 2023
Comment on lines
+39
to
+58
| if !e.debug && len(debugSchedulerSteps) > 0 { | ||
| withParents := strings.HasSuffix(debugSchedulerSteps[0], "^") | ||
| name := strings.TrimSuffix(debugSchedulerSteps[0], "^") | ||
| for _, v := range debugSchedulerSteps { | ||
| if strings.Contains(name, v) { | ||
| e.debug = true | ||
| break | ||
| } | ||
| } | ||
| if !e.debug && withParents { | ||
| for _, vtx := range ed.Vertex.Inputs() { | ||
| name := strings.TrimSuffix(vtx.Vertex.Name(), "^") | ||
| for _, v := range debugSchedulerSteps { | ||
| if strings.Contains(name, v) { | ||
| e.debug = true | ||
| break | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you have some examples?
iiuc it could smth like BUILDKIT_SCHEDULER_DEBUG_STEPS=unpark,^status?
There was a problem hiding this comment.
BUILDKIT_SCHEDULER_DEBUG_STEPS=COPY foo bar^
crazy-max
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new environment variables for allowing debugging scheduler for only specific steps. This is useful because the scheduler debugging is quite verbose so if you run it on production builds it can generate lots of data that is hard to analyze. Old behavior is unchanged.