util/tracing/transform: sync with otel v1.11.1 #3548
Conversation
The files are now synched with `go generate`. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
| func Spans(sdl []*tracepb.ResourceSpans) []tracesdk.ReadOnlySpan { | ||
| // Spans transforms a slice of OpenTelemetry spans into a slice of OTLP | ||
| // ResourceSpans. | ||
| func Spans(sdl []tracesdk.ReadOnlySpan) []*tracepb.ResourceSpans { |
There was a problem hiding this comment.
The function now does the opposite? 🤔
Not sure if we can keep syncing the package with otel
There was a problem hiding this comment.
🤔
Maybe it was replaced with something.
There was a problem hiding this comment.
@Aneurysm9 @MrAlias Any suggestions? This was used to forward the traces from containers/clients to whatever telemetry controller was configured with buildkit daemon, without containers needing to configure telemetry for themselves(they wouldn't have network access to do that anyway).
There was a problem hiding this comment.
I don't think the stated source of this file was actually the source. Looking through the history of that source it always transformed in the direction it currently does.
I can't say with any certainty, but I expect the original in this project was not copied from that source. I think that direction of the transformation is still be possible, but it would need to be written out instead of generated.
There was a problem hiding this comment.
@AkihiroSuda I think I might be remembering it wrong as I also can't find the old code in otel repo. So I guess I wrote this package myself as a reverse version of the upstream one. In that case, we should just look at what has changed in the upstream package and if there are any new keys and logic there, and make matching changes to our package so we don't drop any information during the conversion.
The files are now synched with
go generate.