Fix #3142: undecorate: allow white spaces in cwd #3145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 70ca189 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
urugator
commented
Oct 13, 2021
| @@ -58,7 +57,7 @@ test("run cli with --parseTsAsNonJsx #2754", () => { | |||
| } | |||
| `) | |||
|
|
|||
| mkdirSync(dirname(testNonJsxFile)) | |||
| mkdirSync(dirname(testNonJsxFile), { recursive: true }) | |||
There was a problem hiding this comment.
recursive: true just to silent the EEXIST error, which prevents re-running test without manually deleting the directory first
There was a problem hiding this comment.
I think that has become the default on Node a while back IIRC, so you might be on an older version? Anyway, no harm in there.
mweststrate
reviewed
Oct 14, 2021
| @@ -107,11 +107,11 @@ function interpret_cli_args() { | |||
| spawnBin("jscodeshift", [ | |||
| "--extensions=js,jsx,ts,tsx", | |||
| ...process.argv.filter(arg => arg.startsWith("--")), | |||
| "-t", path.join(__dirname, "src", "undecorate.ts"), | |||
|
|
|||
| "-t", `"${path.join(__dirname, "src", "undecorate.ts")}"`, | |||
There was a problem hiding this comment.
Argh, I was hoping this was the exact problem that passing an argument array would fix. Anyway, thanks for finding this!
mweststrate
approved these changes
Oct 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3142