Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Before this PR,
bun test
would have a ton of failures if you ran it locally. We didn't see this in CI because our runners would test each file separately from one another.After doing some digging, I found a couple of issues:
bun test
maintains globals across modules (unlike jest), so you have to be careful to reset it.done
callback.mobx-state-tree/__tests__/core/model.test.ts
Lines 212 to 230 in fc60d76
And the various solutions:
await
/async
vs callbacks.mobx-state-tree/src/types/complex-types/model.ts
Lines 651 to 658 in fc60d76
Steps to validate locally
All of the following should succeed:
bun test
bun run test:dev
bun run test:prod