Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass encoding parameter to read_text on setup.py? #243

Closed
WolfgangKurz opened this issue Jan 24, 2025 · 1 comment
Closed

pass encoding parameter to read_text on setup.py? #243

WolfgangKurz opened this issue Jan 24, 2025 · 1 comment

Comments

@WolfgangKurz
Copy link

Describe the bug
Cannot install via pip, seems python detecting wrong encoding when read README file.

Trying build from cloned code returns same error.
Image

To Reproduce
Try to install or build at CJK encoding system? (at least my case)

command was:

pip install numpy-quaternion

or

git clone https://github.com/moble/quaternion.git
cd quaternion
python setup.py bdist_wheel

Expected behavior
A clear and concise description of what you expected to happen and why.

Environment (please complete the following information):

  • Windows 11 24H2 (26100.2894), python 3.13.1, CP949 encoding environment
  • install from pip, compile from source
  • Numpy version : 2.2.2 (latest) when trying, 2.1.3 after build succeeded
  • Quaternion version : latest (2024.0.3)

Additional context
i modified setup.py like:

line 15

long_description = (this_directory / "README.md").read_text("utf-8")

and build succeeded.

@moble moble closed this as completed in 951a1cf Jan 24, 2025
@moble
Copy link
Owner

moble commented Jan 24, 2025

Sorry about that, and thanks for finding the solution. I've added your modification to setup.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants