feat: writing unit tests for mobkoi adapters

[nvkftw]

No description provided.

[zeeye]

• There should be a set of default mock objects, at the top of the test file, containing all the required fields. Personally, I prefer using helper functions to return mock objects to prevent the same object from being modified across different tests.
• Break large objects into smaller ones for easier sharing and access in tests.
• Mock objects should only include the data needed to make the adapter work. Prebid.js should throw errors if any required fields are missing(look at the example mentioned at the bottom).
• When you need mock objects contain specific values for the tests. Make a copy of the "default" mock object then replace or remove the fields to match the needs.
• To enhance code readability, fields in mock objects with lengthy values like adm, lurl, and nurl should be replaced with shorter, simplified values. For example:
  • adm: <div>test ad</div>
  • lurl: test.com/loss
  • nurl: test.com/win

Check out test/spec/modules/a1MediaBidAdapter_spec.js. The coding style is quite similar to mine.

[zeeye]

Excellent quality of work. Just need a little bit work on tidying up the mock data. and add a couple more unit tests.

[zeeye]

optional: For the test IDs, use the value like "test-request-id", so that they can be easier to identify

[zeeye]

• Mock data and mock functions and should be above the describe block.
• A few common nested objects should be hoisted, such as ortb2 and bid(prebid bid object)
• Instead of copying the values to the "converted" object, I think it's better to assign the values from one object to another. This way, others can easily see where the values originate.

Suggested change

	const getBidderRequest = () => ({
	const testOrtbId = 'test-ortb-id';
	const getOrtb2 = () => ({
	site: {
	publisher: {
	id: 'mobkoiPublisherId',
	ext: {
	adServerBaseUrl
	}
	},
	},
	})
	const getBidRequest = () => ({
	bidder: 'mobkoi',
	adUnitCode: 'banner-ad',
	transactionId: 'e4895800-1a69-472c-9e6d-277a1ae1a119',
	adUnitId: '6d636e93-32ac-4dc6-8a07-fa4167660265',
	bidId: '3973172c31de61',
	bidderRequestId: testOrtbId,
	auctionId: '90acf3a8-7710-48f9-8009-f7a985d0e605',
	ortb2: getOrtb2()
	})
	const getBidderRequest = () => ({
	bidderCode: 'mobkoi',
	auctionId: '90acf3a8-7710-48f9-8009-f7a985d0e605',
	bidderRequestId: testOrtbId,
	bids: [getBidReuqest()],
	ortb2: getOrtb2()
	})
	const getConvertedBidRequest = () => ({
	id: testOrtbId,
	imp: [{
	id: '3973172c31de61',
	}],
	site: {
	publisher: {
	id: 'mobkoiPublisherId',
	ext: {
	adServerBaseUrl
	}
	},
	},
	test: 0
	})

[zeeye]

Should always reads expected value from the mock data like validating the requestId at line 170

[zeeye]

• all log functions from '../src/utils.js' that the adapter should be "stubbed" with Sinon. To avoid messages been log to console when executing tests.
• ajax should also "stubbed" to avoid accidentally making api calls when executing the tests.
• add tests to ensure postAjax and sendGetRequest are called. Stub those two util functions in your tests.
  • sendGetRequest should be called in BIDDER_DONE and BID_WON event
  • postAjax should be called in BIDDER_DONE event

[zeeye]

It seems you forgot to replace the default adm value with something more meaningful for this test.