-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow airplane mode control #1672
feat: allow airplane mode control #1672
Conversation
087e275
to
77db04d
Compare
77db04d
to
efc4977
Compare
@NyCodeGHG Nice 🎉 Let's update it to be a single command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@axelniklasson hi, thank you for the review. |
Hey, that's fair and a good use case to me. Let's keep the API as it is but also add |
maestro-orchestra-models/src/main/java/maestro/orchestra/Commands.kt
Outdated
Show resolved
Hide resolved
maestro-orchestra-models/src/main/java/maestro/orchestra/Commands.kt
Outdated
Show resolved
Hide resolved
a808812
to
60b1cbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this works well for me! Can you also raise a PR in https://github.com/mobile-dev-inc/maestro-docs as well as adding another test case to the integration tests? Thanks!
maestro-orchestra-models/src/main/java/maestro/orchestra/Commands.kt
Outdated
Show resolved
Hide resolved
60b1cbb
to
409d7a8
Compare
@axelniklasson |
@NyCodeGHG let's add another test case to IntegrationTest.kt with an example Flow that uses the commands to ensure that all commands are parsed correctly etc. You can take a look at the other test cases to get a feel for how we usually test new commands |
Thanks @NyCodeGHG! Merging this now but please do also raise a PR in https://github.com/mobile-dev-inc/maestro-docs documenting the new commands - we'll merge it when we make the next release 👍 Thanks again for your contribution! |
will do! |
Proposed Changes
add a new command for controlling the airplane mode of android devices.
Testing
ran the following flow on android 27 and 28 emulators: