Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Webhooks #273

Merged
merged 11 commits into from
Jan 24, 2025
Merged

✨ Webhooks #273

merged 11 commits into from
Jan 24, 2025

Conversation

brunobuddy
Copy link
Contributor

@brunobuddy brunobuddy commented Jan 24, 2025

Description

This PR adds webhook feature to Manifest

How can it be tested?

  • Pull the mnfst/website "webhooks branch and launch the docs
  • Check the webhooks documentation
  • Go to that amazing site: https://webhook.site/ to generate your unique webhook URL to test webhooks
  • Play around

Ex usage with webhook.site:

    hooks:
      beforeCreate:
        - { url: "https://webhook.site/5b9-fe9ese-geacd-8fb5-370c521c50a2" }

Impacted packages

Check the NPM packages that require a new publication or release:

Check list before submitting

  • I created the related changeset for my changes with npx changeset
  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • I wrote the relative tests
  • I created a PR for the documentation if necessary and attached the link to this PR
  • This PR is wrote in a clear language and correctly labeled

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 70.83333% with 21 lines in your changes missing coverage. Please review.

Project coverage is 61.34%. Comparing base (01aed5b) to head (68bf2c0).
Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
...ackages/core/manifest/src/hook/hook.interceptor.ts 66.66% 10 Missing and 2 partials ⚠️
packages/core/manifest/src/hook/hook.service.ts 69.23% 4 Missing ⚠️
...es/core/manifest/src/crud/services/crud.service.ts 0.00% 3 Missing ⚠️
...t/src/manifest/services/entity-manifest.service.ts 90.00% 1 Missing ⚠️
...ore/manifest/src/manifest/services/yaml.service.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   56.39%   61.34%   +4.94%     
==========================================
  Files          42       45       +3     
  Lines        1204     1296      +92     
  Branches      289      325      +36     
==========================================
+ Hits          679      795     +116     
+ Misses        524      461      -63     
- Partials        1       40      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brunobuddy brunobuddy marked this pull request as ready for review January 24, 2025 13:06
@brunobuddy brunobuddy merged commit 5f1f1d7 into master Jan 24, 2025
6 checks passed
@brunobuddy brunobuddy deleted the hooks branch January 24, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants