Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(entityManifest): admin props not displayed in manifest #270

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

brunobuddy
Copy link
Contributor

Description

Bugfix

Related Issues

How can it be tested?

Launch admin panel and edit admins (CRUD). Everything should work

Impacted packages

Check the NPM packages that require a new publication or release:

Check list before submitting

  • I created the related changeset for my changes with npx changeset
  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • I wrote the relative tests
  • I created a PR for the documentation if necessary and attached the link to this PR
  • This PR is wrote in a clear language and correctly labeled

@brunobuddy brunobuddy added the bug Something isn't working label Jan 22, 2025
@brunobuddy brunobuddy requested a review from SebConejo January 22, 2025 11:01
@brunobuddy brunobuddy self-assigned this Jan 22, 2025
@brunobuddy brunobuddy linked an issue Jan 22, 2025 that may be closed by this pull request
@brunobuddy brunobuddy marked this pull request as ready for review January 22, 2025 11:01
@brunobuddy brunobuddy changed the title fix(entityManifest): admin props not displayed in manifest, Closes #269 🐛 fix(entityManifest): admin props not displayed in manifest Jan 22, 2025
@brunobuddy brunobuddy changed the title 🐛 fix(entityManifest): admin props not displayed in manifest 🐛 fix(entityManifest): admin props not displayed in manifest Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.39%. Comparing base (f32492d) to head (01aed5b).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   56.39%   56.39%           
=======================================
  Files          42       42           
  Lines        1204     1204           
  Branches      298      289    -9     
=======================================
  Hits          679      679           
- Misses        486      524   +38     
+ Partials       39        1   -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brunobuddy brunobuddy merged commit 83e5a58 into master Jan 22, 2025
8 checks passed
@brunobuddy brunobuddy deleted the 269-admin-panel-cannot-manage-admins branch January 22, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin panel : cannot manage admins
2 participants