Add QuSpin .lvm file loader and tests for MNE Raw object creation #13098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the read_raw_quspin_lvm function to parse QuSpin N1 .lvm files, converting the data to an MNE Raw object. This includes handling the metadata (e.g., sensor channels, trigger channels, and units) and creating an appropriate Info object. Add a new test file, test_quspin.py, to verify the functionality of the read_raw_quspin_lvm function. The tests cover parsing of the .lvm file, correct handling of metadata, and creation of an appropriate MNE Raw object. - Added quspin.py with read_raw_quspin_lvm function - Added __init__.py to initialize the quspin module - Added test_quspin.py with unit tests for QuSpin loader - Added quspin_N1_test_data.lvm, a small sample dataset for testing
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
for more information, see https://pre-commit.ci
larsoner
reviewed
Feb 3, 2025
| @@ -0,0 +1,62 @@ | |||
| LabVIEW Measurement | |||
There was a problem hiding this comment.
We have moved away from storing test data in MNE-Python, could you add the file to https://github.com/mne-tools/mne-testing-data ?
|
I'll give the code a more in-depth review soon, but in the meantime just a comment above about moving the test file ☝️ . If it's unclear what you need to do from the README in that repo I can help! |
|
Hi Eric,
Thanks for the feedback! I'll create PR with the quspin test data following
the instructions in the ReadMe. Will reach out if I hit any snags
(expecting to since I'm quite new to contributing -- appreciate your
patience in the meantime!)
Best regards,
Dave
…On Mon, Feb 3, 2025 at 12:16 PM Eric Larson ***@***.***> wrote:
I'll give the code a more in-depth review soon, but in the meantime just a
comment above about moving the test file ☝️ . If it's unclear what you need
to do from the README in that repo I can help!
—
Reply to this email directly, view it on GitHub
<#13098 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLLYAB5IRHGP7DSAGGNIZ3L2N66CLAVCNFSM6AAAAABWMZ5WSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZRHA3DENZRGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
David C. Bobela
Physicist, QuSpin Inc.,
331 South 104th Street, Suite 130
Louisville, CO 80027
Ph: 720-982-8807
Email: ***@***.*** ***@***.***>
Website: http://www.quspin.com/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Addresses issue #12881
What does this implement/fix?
This pull request introduces the read_raw_quspin_lvm function to handle .lvm files generated by the QuSpin N1 system. The function reads and parses the .lvm file, converts the data to an MNE Raw object, and creates the corresponding Info object. Additionally, tests and sample data are included to validate the loader's functionality. Specific changes are:
Additional information