Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove URL-based reqs #672

Merged
merged 4 commits into from
Nov 30, 2022
Merged

MAINT: Remove URL-based reqs #672

merged 4 commits into from
Nov 30, 2022

Conversation

larsoner
Copy link
Member

I tried to upload to PyPI and got:

Invalid value for requires_dist. Error: Can't have direct dependency: "autoreject @ https://api.github.com/repos/autoreject/autoreject/zipball/master ; extra == 'dev'"

It seems that PyPI does not want any requirements to be URL-based, so this PR removes the dev target that contained all URL-based main requirements.

@larsoner larsoner added this to the 1.0 milestone Nov 30, 2022
@larsoner
Copy link
Member Author

... whereas on this PR:

https://pypi.org/project/mne-bids-pipeline/

@hoechenberger
Copy link
Member

Do we need to cut a new release of autoreject?

@hoechenberger
Copy link
Member

Oh never mind, I misunderstood what was going on here. Mmh that's a bummer really!

@hoechenberger hoechenberger enabled auto-merge (squash) November 30, 2022 20:53
@hoechenberger
Copy link
Member

I tried to upload to PyPI and got:

Allegedly, twine check should catch this; we should add this to our workflow

@larsoner
Copy link
Member Author

Allegedly, twine check should catch this; we should add this to our workflow

Maybe it won't actually? I didn't read the whole thing but this is still open: pypa/twine#430

But in any case, I now added:

  1. A wheel build action, including a twine check --strict
  2. A PyPI-upload action with proper PyPI var
  3. setuptools_scm var tag_regex to strip the v from tags so that v1.0.0 can be the name of our tag in our first real release (following MNE-Python convention)

@larsoner
Copy link
Member Author

Do we need to cut a new release of autoreject?

This would be a good idea actually, since the latest release there was some fix of nan handling I think?

@hoechenberger hoechenberger merged commit 5c2b9e2 into mne-tools:main Nov 30, 2022
@hoechenberger
Copy link
Member

Thanks @larsoner!

@larsoner larsoner deleted the reqs branch November 30, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants