[ISSUE-41] Bugfix: Parsing text/plain and text/html attachments
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a text/plain and a text/html content-disposition: attachment files. Modify letters_test.go to expect text/plain and text/html attachments to be correctly parsed.
…arsePart() to correctly handle attachments of any content type. Simplify parsePart() loop. Simplify isInlineFile() and isAttachedFile() to not parse Content Disposition header multiple times.
text/plain and text/html attachmentstext/plain and text/html attachments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
As reported by @naidishuli in #41, we have been parsing
text/plainandtext/htmlattachments incorrectly. Even when they are attached with theContent-Disposition: attachmentheader, we mistakenly treat them as text and HTML content, respectively.This PR addresses and resolves this problem.
Commits:
text/plainand atext/htmlcontent-disposition: attachmentfiles.letters_test.goto expect text/plain and text/html attachments to be correctly parsed.parsePart()to correctly handle attachments of any content type.parsePart()loop.isInlineFile()andisAttachedFile()to not parse Content Disposition header multiple times.