Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NULL ObjectReference #146

Merged
merged 3 commits into from
Apr 27, 2024
Merged

Remove NULL ObjectReference #146

merged 3 commits into from
Apr 27, 2024

Conversation

wks
Copy link
Contributor

@wks wks commented Apr 24, 2024

Parent PR: mmtk/mmtk-core#1064

@wks wks marked this pull request as ready for review April 24, 2024 16:50
@wks wks requested a review from qinsoon April 24, 2024 16:50
@wks wks mentioned this pull request Apr 24, 2024
Merged
@wks
Copy link
Contributor Author

wks commented Apr 24, 2024

I managed to get the tests passing.

I made an assumption that a SimpleEdge may hold a NULL pointer. It is strange because AFAIK Julia uses nothing and missing to represent non-existing values. But when I tried to build Julia, I did observe some SimpleEdge holding NULL pointer. Currently, I just let JuliaVMEdge::load() return None if it is a SimpleEdge and the slot holds the value 0. MMTk core can gracefully skip such edges.

qinsoon
qinsoon approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmtkgc-bot mmtkgc-bot enabled auto-merge (squash) April 27, 2024 14:32
@mmtkgc-bot mmtkgc-bot merged commit 309a6ae into mmtk:master Apr 27, 2024
17 checks passed
@qinsoon qinsoon mentioned this pull request May 22, 2024
Closed
qinsoon pushed a commit to qinsoon/mmtk-julia that referenced this pull request May 22, 2024
@wks @mmtkgc-bot @qinsoon
Remove NULL ObjectReference (mmtk#146)
54b8e44 
Parent PR: mmtk/mmtk-core#1064

---------

Co-authored-by: mmtkgc-bot <mmtkgc.bot@gmail.com>
@qinsoon qinsoon mentioned this pull request May 22, 2024
Merged
qinsoon added a commit that referenced this pull request Jun 17, 2024
@qinsoon @wks @mmtkgc-bot
Backport #146 #148 #150 (#152)
cab4348 
Backport #146, #148, #150

---------

Co-authored-by: Kunshan Wang <wks1986@gmail.com>
Co-authored-by: mmtkgc-bot <mmtkgc.bot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinsoon qinsoon qinsoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wks @qinsoon @mmtkgc-bot