Remove repos/jikesrvm submodule #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2022
wks
reviewed
Feb 24, 2022
…er tree in README.
qinsoon
added a commit
to mmtk/mmtk-core
that referenced
this pull request
Feb 25, 2022
This PR mainly makes changes to CI configs to cooperate with the bindings' change of removing VM submodules (mmtk/mmtk-jikesrvm#101 and mmtk/mmtk-openjdk#140). Changes: * Made CI call `ci-checkout.sh` after checking out binding repos for OpenJDK and JikesRVM * Changed how we collect binding info: * Now we use a reusable workflow to extract binding info (repos and refs) from one comment in a PR. * The workflow is used by both binding correctness tests and benchmarks. * Our CI now can run tests and benchmarks for binding PRs submitted from a fork. * This closes #246. * Updated porting guide for a more logically correct folder structure. * This closes #502. * Updated `ci-perf-kit` to 0.6.6, which changes the command line arguments used for JikesRVM (we no longer support setting MMTk options with camelCase - the fix changes options to snake_case). Related PRs: * mmtk/mmtk-openjdk#140 * mmtk/mmtk-jikesrvm#101 * mmtk/mmtk-v8#55
qinsoon
added a commit
to mmtk/mmtk-v8
that referenced
this pull request
Feb 27, 2022
This PR moved some version metadata from CI scripts to `mmtk/Cargo.toml`. This PR makes the mmtk-v8 repo more consistent with [mmtk-openjdk](mmtk/mmtk-openjdk#140) and [mmtk-jikesrvm](mmtk/mmtk-jikesrvm#101).
|
I would suggest merging this pull request (allow merging this PR without all tests passed), as 1. the problem is not introduced by this pull request, and 2. without this pull request, we cannot run proper CI tests for the binding. I will do a pull request to fix the problem. What do you think? @wks |
|
@qinsoon I think it is OK to merge it now. It temporarily breaks some tests, but as long as it doesn't take long to provide a proper fix, it should be OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the git submodule for JikesRVM. This PR closes #89.
Changes:
mmtk/Cargo.toml.common.shto.github/scripts, which is included by each CI shell script.ci-checkout.shto.github/scriptsthat checks out the correct OpenJDK version for CI.README.