-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discontiguous mark compact space support #939
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/mmtk-core into discontig-mark-compact
tianleq
reviewed
Sep 5, 2023
qinsoon
reviewed
Sep 5, 2023
qinsoon
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tianleq
approved these changes
Sep 5, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
#939 makes MarkCompact GC allocate large objects into LOS, instead of mark-compacting everything. However, LOS should be released and re-prepared properly, otherwise marking in the pointer forwarding trace will not behave correctly. This should fix the OpenJDK binding test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR-testing
Run binding tests for the pull request (deprecated: use PR-extended-testing instead)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds discontiguous heap support for mark compact GC, and rewrites the forwarding pointer calculation and compaction code to be compactable to both contiguous and discontiguous spaces.
Fixes #930