Checking if the referent has been cleared #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyuzhao
pushed a commit
to wenyuzhao/mmtk-core
that referenced
this pull request
Mar 20, 2023
Some runtimes clear reference to a different value other than null. This PR adds a method to the ReferenceGlue trait to check if a reference is cleared and replac the checks in mmtk-core to call this method instead. Therefore, bindings can overwrite the method `is_referent_cleared` to do the check properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Julia referents are set to
jl_nothinginstead ofnullto indicate that a reference has been cleared.I have added a default method to the ReferenceGlue trait and replaced the checks in mmtk-core to call this method instead. Therefore, bindings can overwrite the method
is_referent_clearedto do the check properly.