Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set-output will be deprecated in Github actions #927

Closed
qinsoon opened this issue Aug 30, 2023 · 0 comments · Fixed by #1059
Closed

set-output will be deprecated in Github actions #927

qinsoon opened this issue Aug 30, 2023 · 0 comments · Fixed by #1059
Labels
A-ops Area: Operations (e.g. CI) P-high Priority: High. A high-priority issue should be fixed as soon as possible.

Comments

@qinsoon
Copy link
Member

qinsoon commented Aug 30, 2023

See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

These are what we need to do/check:

  1. we need to change set-output to
echo "{name}={value}" >> $GITHUB_OUTPUT
  1. Upgrade our self-hosted Github runner to 2.297.0 or above.
@qinsoon qinsoon added the A-ops Area: Operations (e.g. CI) label Aug 30, 2023
@qinsoon qinsoon added the P-high Priority: High. A high-priority issue should be fixed as soon as possible. label Oct 25, 2023
@qinsoon qinsoon mentioned this issue Jan 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 3, 2024
@qinsoon
Stop using the deprecated set-output in our CI configs (#1059)
e7143b9 
This closes #927. This PR also
includes a few changes to make style check pass for the stable Rust
1.75.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ops Area: Operations (e.g. CI) P-high Priority: High. A high-priority issue should be fixed as soon as possible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop using the deprecated set-output in our CI configs qinsoon/mmtk-core
1 participant
@qinsoon