Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Scikit-Learn ExtraTreesRegressor to allowed models for TreeExplainer #309

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Deathn0t
Copy link

Hello,

I am opening this PR to add the ExtraTreesRegressor as part of allowed models for the TreeExplainer.

I noticed the ExtraTreesClassifier already added is not part of the tests because it is not part of the TREE_MODEL_FIXTURES list. Therefore, I did not add it. Let me know if you prefer to add it.

I tested the TreeExplainer live with ExtraTreesRegressor and it works.

@Deathn0t
Copy link
Author

I pushed the fix for the test that failed.

I just found that issue #277 corresponds to this PR.

According to my knowledge, RandomForestPOSTFIX and ExtraTreesPOSTFIX in Scikit-Learn are based on the same code DecisionTreePOSTFIX. The difference is mostly in fixing splitter="best" for RandomForestPOSTFIX and splitter="random" for ExtraTreesPOSTFIX. Here is a hint to that:

@mmschlk mmschlk self-assigned this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants