Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abbreviated_names should be optional #281

Closed
xingzhongyu opened this issue Dec 1, 2024 · 1 comment
Closed

abbreviated_names should be optional #281

xingzhongyu opened this issue Dec 1, 2024 · 1 comment
Assignees
@mmschlk
Labels
maintenance plot

Comments

@xingzhongyu
Copy link

abbreviate_feature_names is not good for plotting, or at least avoids the possibility of label duplication.
@mmschlk mmschlk self-assigned this Dec 3, 2024
@mmschlk mmschlk moved this to 🏗 In progress in shapiq development Dec 3, 2024
mmschlk added a commit that referenced this issue Dec 3, 2024
@mmschlk
makes abbreviation in plots optional and closes #281
75918c7
@mmschlk
Copy link
Owner

mmschlk commented Dec 3, 2024

Oh yes, good point! I added a bool flag to the plots, which abbreviate feature names, indicating if you want to abbreviate the feature names or not.

@mmschlk mmschlk moved this from 🏗 In progress to 👀 In review in shapiq development Dec 3, 2024
@mmschlk mmschlk mentioned this issue Dec 3, 2024
Merged
@mmschlk mmschlk closed this as completed in fadf90d Dec 4, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in shapiq development Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmschlk mmschlk

Labels
maintenance plot
Projects
shapiq development
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmschlk @xingzhongyu