-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jekyll 3.0 points out Liquid rendering error in posts.html #141
Comments
Seems valid. Care to submit a PR so I can test it out. Just want to make sure the Disqus script isn't loading if those conditions aren't met. In the past its mistakenly loaded on pages even when someone hadn't included a shortname in their The bit with the parentheses was submitted as a PR if I recalled correctly to cover cases where someone might want comments to appear on all posts without having to manually add |
Remove trailing whitespace
Should be fixed as of 2.3.2 |
* mmistakes/master: (102 commits) Improve readability of .scss files Change `spin` to `adjust-hue` - Close mmistakes#201 Update modified date Update gems removing parentheses, see issue mmistakes#141 Fix search.js interferace with other forms - cc/ issue mmistakes#194 Remove Octopress configuration Update README Remove feed.xml and replace with jekyll-feed gem Replace {% highlight %} Jekyll tags with GFM ``` Remove Octopress dependency Update gems removed pro tip on applying for twitter cards Ignore .less files not files containing "less" Sanitize excerpts in search.json - Fixes mmistakes#191 Normalize auto {{ post.excerpts }} - When excerpt: isn't set in a post's YAML Front Matter fallback to Jekyll's auto excerpts - Strip HTML from auto excerpts and MathJax code with Liquid filters applied to post listings (index.html, /blog/, /articles/) Support Jekyll 3.0 - Update to Jekyll v3.0 - Switch from Pygments.rb to Rouge for syntax highlighting - Include jekyll-gist gem - Update theme documentation Fix typo in `bundle exec` Update dependencies Update links - Remove Made Mistakes from header nav - Update So Simple footer link ... # Conflicts: # _config.yml # _data/authors.yml # _data/navigation.yml # _includes/footer.html # _layouts/page.html # _layouts/post.html # _posts/articles/2011-03-10-sample-post.md # _posts/articles/2012-05-22-readability-post.md # _posts/articles/2013-05-22-sample-post-images.md # _posts/articles/2013-05-23-readability-feature-post.md # _posts/articles/2013-06-25-video-post.md # _posts/articles/2013-08-16-code-highlighting-post.md # _posts/articles/2014-06-19-author-override.md # _posts/blog/2014-08-08-hello-world.md # about/index.md # feed.xml # images/michael-rose-photo.jpg # images/so-simple-sample-image-1.jpg # images/so-simple-sample-image-2.jpg # images/so-simple-sample-image-3.jpg # images/so-simple-sample-image-4.jpg # images/so-simple-sample-image-5.jpg # images/so-simple-sample-image-6.jpg # images/so-simple-sample-image-7.jpg # theme-setup/index.md
Edit: Error fixed, see explanation.
So I upgraded to the newest jekyll beta (3.0 beta 2) and the good news is that most things work, except for a quick fix needed in posts.html. After upgrading while trying to generate the site with build jekyll i encountered a weird error for liquid
and after looking at _layout/posts.html and searching the issue online it seems that the error always existed, parentheses are not permitted by Liquid but for the first time it will prevent a build of a site because Jekyll 3 will show the error. So to fix the issue we just remove the offending parentheses in the disqus part of of post.html starting at line 39 like so
The text was updated successfully, but these errors were encountered: