Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_row can accept an array with feature rows #2839

Closed
wants to merge 2 commits into from

Conversation

lsolesen
Copy link
Contributor

This is an enhancement or feature.

Summary

This pull request makes the feature_row more versatile, so you can add rows without having to specify the rows in the frontmatter.

Context

There might be many situations where you want to store your feature rows other places than in the frontmatter and be able to query your rows. This makes it possible to still use the standard theme.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.

This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

@lsolesen
Copy link
Contributor Author

I think this is beneficial, as it makes it possible to also use rows=page.feature_row or pull your feature rows from other places.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.

This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

@lsolesen
Copy link
Contributor Author

lsolesen commented Aug 1, 2021

@mmistakes I think this should be kept open, as it will make it more flexible to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant