Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Homepage link to 404 and improve its apology #2819

Closed
wants to merge 3 commits into from
Closed

Add Homepage link to 404 and improve its apology #2819

wants to merge 3 commits into from

Conversation

rlaphoenix
Copy link
Contributor

This is an enhancement or feature.

Summary

This makes the 404 page more visually appealing as well as more functional, more of a reason to exist.

Context

N/A

@rlaphoenix
Copy link
Contributor Author

Preview:

image

docs/_pages/404.md Outdated Show resolved Hide resolved
docs/_pages/404.md Outdated Show resolved Hide resolved
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.

This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

@rlaphoenix
Copy link
Contributor Author

Any further review? potential merge?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.

This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

@mmistakes
Copy link
Owner

Thanks for the PR but closing this with the wontfix label.
The 404 page here is just an example I'm using for the demo site. It can easily be customized as you have to fit your site's needs.

@iBug
Copy link
Collaborator

iBug commented Jul 23, 2021

@mmistakes Honestly I'd say it's better to merge this in. It's certainly an improvement for your docs site, and you know, there could be more 404 links from time to time as the docs are updated and whatever happens...

@mmistakes
Copy link
Owner

@iBug Don't think I agree. I'm seeing a slightly reworded error text and a home link that already exists in the masthead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants