-
Notifications
You must be signed in to change notification settings - Fork 26k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Homepage link to 404 and improve its apology #2819
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions. |
Any further review? potential merge? |
This pull request has been automatically marked as stale because it has not had recent activity. This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions. |
Thanks for the PR but closing this with the |
@mmistakes Honestly I'd say it's better to merge this in. It's certainly an improvement for your docs site, and you know, there could be more 404 links from time to time as the docs are updated and whatever happens... |
@iBug Don't think I agree. I'm seeing a slightly reworded error text and a home link that already exists in the masthead. |
This is an enhancement or feature.
Summary
This makes the 404 page more visually appealing as well as more functional, more of a reason to exist.
Context
N/A