Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility for SEO title #2539

Closed
wants to merge 6 commits into from
Closed

Conversation

lsolesen
Copy link
Contributor

@lsolesen lsolesen commented May 21, 2020

This is an enhancement or feature.

Summary

This makes it possible to add a SEO optimized title to the page like it is possible to have SEO optimized description. Related to #2371

Context

_includes/seo.html Outdated Show resolved Hide resolved
_includes/seo.html Show resolved Hide resolved
@iBug
Copy link
Collaborator

iBug commented May 21, 2020

I'm afraid you didn't understand my comments on title_separator. In short, you need to keep it intact for existing users, i.e., users shouldn't be affected by your changes if they're relying on the current implementation.

@lsolesen
Copy link
Contributor Author

@iBug You are completely right. Something went wrong. Please review again.

@lsolesen
Copy link
Contributor Author

@mmistakes Did you think more about inclusion of this?

@lsolesen
Copy link
Contributor Author

@mmistakes @iBug Did you think more about this.

_includes/seo.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@iBug iBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem with this now, though I'm unconfident about @mmistakes 's views on this.

iBug referenced this pull request May 13, 2021
@lsolesen
Copy link
Contributor Author

lsolesen commented Aug 1, 2021

How do one avoid that pull requests does not go stale?

@iBug
Copy link
Collaborator

iBug commented May 5, 2024

Now that seo.html has gone through some non-trivial changes, please re-implement this on top of current master and open a new PR - hopefully it'll be much easier to do so.

I'll be happy to review and merge when it comes up, just make sure to ping me.

@iBug iBug closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants