Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alt to avatar #1226

Merged
merged 2 commits into from
Sep 20, 2017
Merged

Added alt to avatar #1226

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2958856
Added alt to avatar
lsolesen Sep 5, 2017
d56bda5
Do not include Avatar in description - just name
lsolesen Sep 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _includes/comment.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<article id="comment{{ include.index }}" class="js-comment comment" itemprop="comment" itemscope itemtype="http://schema.org/Comment">
<div class="comment__avatar-wrapper">
<img class="comment__avatar" src="https://www.gravatar.com/avatar/{{ include.email }}?d=mm&s=80">
<img class="comment__avatar" src="https://www.gravatar.com/avatar/{{ include.email }}?d=mm&s=80" alt="Avatar for {{ include.name }}">
Copy link
Owner

@mmistakes mmistakes Sep 5, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will probably want to use the same method the rest of the theme uses for "localizing" text strings so it can be translated if need be.

Something like alt="{{ site.data.ui-text[site.locale].avatar_for | default: "Avatar for" }} for {{ include.name }}"

And then add avatar_for: "Avatar for" under the English locales in _data/ui-txt.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the Avatar part which seems to be more clever just to have the name instead of having to localize. I could do what you originally suggested also, if you think that it is more clever.

</div>
<div class="comment__content-wrapper">
<h3 class="comment__author" itemprop="author" itemscope itemtype="http://schema.org/Person">
Expand All @@ -19,4 +19,4 @@ <h3 class="comment__author" itemprop="author" itemscope itemtype="http://schema.
</p>
<div itemprop="text">{{ include.message | markdownify }}</div>
</div>
</article>
</article>