-
Notifications
You must be signed in to change notification settings - Fork 26k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make staticman_v3 default Staticman comment provider #2036
Comments
#1956 is related. see: #2034 (comment) |
@mmistakes I just read your very detailed article on Staticman from a couple of years ago: https://mademistakes.com/articles/improving-jekyll-static-comments/ |
Nested comments are not supported in any of my themes. If you’re starting fresh it’s much easier since you can use an internal Staticman field to assign a unique identifier for each comment as a way of referencing their parent. When I implemented it on my personal site I imported hundreds of comments from Disqus which left me with legacy comments without these UIDs. If you search around there are others who have improved on my implementation. I don’t have the links handy but they exist. |
Thanks again for the quick response!
…On Sun, Jan 20, 2019 at 5:49 PM Michael Rose ***@***.***> wrote:
Nested comments are not supported in any of my themes.
Have a look on my personal site and repo to see how I’ve done it.
If you’re starting fresh it’s much easier since you can use an internal
Staticman field to assign a unique identifier for each comment as a way of
referencing their parent. When I implemented it on my personal site I
imported hundreds from Disqus which didn’t left me with comments without
UIDs.
If you search around there are others who have improved on my
implementation. I don’t have the links handy but they exist.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2036 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AqZFOIA7gzJ1fd_-QDxHdiWxfsuMdVMTks5vFKwagaJpZM4aJX2j>
.
|
I think this issue was closed without addressing the original ask, which was to introduce a |
@deadlydog Staticman 3 is supported. See the docs on how to configure it. https://mmistakes.github.io/minimal-mistakes/docs/configuration/#staticman-v3 |
Ahhh perfect. I hadn't found that link; that looks like exactly what I need. Thanks for the super fast responses @mmistakes . You can really tell you are passionate about your projects, and I appreciate it :) |
Summary
This is a skeleton issue based on #2034
The backend service for staticman v2 has become overwhelmed. Users are able to set up their own backend, but the developers have created a github application which resolves the issue and avoids the need to create this custom backend.
In effect, whilst the v2 api will continue to run, v3 offers a much smoother and more stable implementation and should be the default going forward.
This should involve small changes to _config.yml, the bundled staticman.yml, _includes/comments.html and related documentation + testing.
My current use case for minimal-mistakes is helping me to pass my exams in horticulture: they're a few weeks time. eek. It's a nice little PR I'd be happy to take on, but I'm very good at letting coding be a distraction to learning the actual plant stuff, so if this is accepted and anyone else is keen before mid-February, please do carry on 👍
The text was updated successfully, but these errors were encountered: